Open
Conversation
… to wrong location though
Owner
|
@shinji-kono , I wrote a bunch of comments (in-line with your original changes). I am just wondering if you have seen these? There are even more new features added recently, but none of the concerns are yet addressed. I guess it would be easier if we could keep use one pull request per one logical change. |
Author
|
Ya, that's make sense. I think I checked your update, but I missed some. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JumpToError counslt error message contents (byte2line won't work because of neovim's unapplied patch)
add indent on make case handling
chose different syntax on hole and unsolved metas
ingnore error on normalize