update window-icons/window-icons.patch#49
Open
laur89 wants to merge 10 commits intoashinkarov:masterfrom
Open
Conversation
Owner
|
Thanks for the contribution, a few minor notes though:
|
Author
|
Will do later when I have more time.
{v,h}split seem to have different definitions. |
- note currenlty only works nicely when title_align=left (default); could be modified to support centered- and right alignment, but not going to for the sake of keeping the patch as simple as possible.
- this merely swaps the vsplit & hsplit displayed labels (V & H);
- breaking changes from i3/i3#3759
filename was updated upstream
- add braces to the if-block
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
could be modified to support centered- and right alignment, but not
going to for the sake of keeping the patch as simple as possible.