feat: ical metata props #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR expands iCalendar event properties by adding support for calendar name, event status, time transparency, and categories. These additions enhance the metadata available for calendar events and improve filtering capabilities.
Key changes:
- Added four new properties to
ICalEvent:calendar_name,status,transp, andcategories - Extended parsing logic to extract these properties from iCalendar files
- Added comprehensive test coverage for the new properties
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| calgebra/ical.py | Added new fields to ICalEvent dataclass, updated _parse_vevent to extract calendar name, status, transp, and categories properties |
| tests/test_ical.py | Added test cases for calendar name extraction, status/transp parsing, and categories handling |
| docs/API.md | Updated documentation to describe the new event properties and field helpers |
| calgebra/docs/API.md | Duplicate documentation update (same as docs/API.md) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expands the ical event properties.