Skip to content

Conversation

@ashenfad
Copy link
Owner

No description provided.

@ashenfad ashenfad requested a review from Copilot December 30, 2025 00:31
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes two main issues related to task cancellation: correcting when cancellation is checked during task execution, and updating XML rendering to use consistent XML tags for task outcomes.

Key Changes:

  • Test updates to verify cancellation occurs during task execution rather than between separate task runs
  • XML rendering now uses structured tags (<TASK_SUCCESS>, <TASK_FAIL>, <TASK_CLARIFY>, <TASK_CANCELLED>) instead of emoji-prefixed text
  • Stale cancellation signals are now cleared at task start to prevent false cancellations

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/agex/test_cancellation.py Updated tests to verify cancellation during task execution via event callbacks instead of between runs
tests/agex/render/test_xml.py Updated assertions to check for XML tags instead of emoji markers
agex/render/xml.py Implemented XML tag rendering for all task outcome events (success, fail, clarify, cancelled)
agex/llm/xml.py Added new XML tag constants for task outcomes
agex/llm/dummy_client.py Added renderer selection support to enable XML rendering in tests
agex/agent/loop/sync_loop.py Added stale cancellation signal cleanup at task start and reordered event logging before snapshot
agex/agent/loop/async_loop.py Applied same cancellation signal cleanup as sync version
agex/render/definitions.py Added strip_all_modules parameter to remove module prefixes from type annotations in directly-registered classes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ashenfad ashenfad merged commit c6f53a9 into main Dec 30, 2025
7 checks passed
@ashenfad ashenfad deleted the bugs branch December 30, 2025 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants