test: improve version sorting consistency across tests - addresses #2…#222
Open
M-Gonzalo wants to merge 1 commit intoash-project:mainfrom
Open
test: improve version sorting consistency across tests - addresses #2…#222M-Gonzalo wants to merge 1 commit intoash-project:mainfrom
M-Gonzalo wants to merge 1 commit intoash-project:mainfrom
Conversation
Contributor
|
I don't think we want to do this actually. The tests are meant to be asserting on the order of the versions themselves. At least, AFAIK they are. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…21 on issue tracker
Contributor checklist
Leave anything that you believe does not apply unchecked.
It looks reductive but this is the less invasive way I found to consistently pass all tests. Ran the whole suite thousands of times. There's still some sporadic failure here and there, but it's much much less frequent now.