Skip to content

ASFCUMULUS-845: upgrade rain-api-core to set additional properties of session cookie#866

Merged
asjohnston-asf merged 2 commits intoasfadmin:mainfrom
asjohnston-asf:main
Dec 1, 2025
Merged

ASFCUMULUS-845: upgrade rain-api-core to set additional properties of session cookie#866
asjohnston-asf merged 2 commits intoasfadmin:mainfrom
asjohnston-asf:main

Conversation

@asjohnston-asf
Copy link
Member

@asjohnston-asf asjohnston-asf commented Nov 19, 2025

Pull Request Checklist

I have:

  • performed a self review of my code I&A code style
    • Resources and Data Structures are sorted by ABC or a defined sorting pattern
  • updated the documentation accordingly
  • verified required action checks are passing
  • deployed my code and all new and existing E2E/Integration tests passed
  • bumped the version number as appropriate

@asjohnston-asf asjohnston-asf changed the title ASFCUMULUS-845: upgrade rain-api-core to set additional properties of… ASFCUMULUS-845: upgrade rain-api-core to set additional properties of session cookie Nov 19, 2025
@asjohnston-asf asjohnston-asf marked this pull request as ready for review November 24, 2025 20:48
@reweeden
Copy link
Contributor

I believe you'll need to run make lock for this to take effect as described in the readme here: https://github.com/asfadmin/thin-egress-app?tab=readme-ov-file#python-dependencies. That will re-compile the .in file to a .txt file which is what actually gets used in the build.

I'd also recommend giving all the dependencies a bump before this release since it's been a little while since we've done that. You could do that either in this PR or as a separate PR. The way I'd do it is with a touch requirements/requirements*.in followed by a make lock.

@asjohnston-asf
Copy link
Member Author

Done. I suspect the dependency update makes #864 obsolete.

Copy link
Contributor

@reweeden reweeden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, the dependabot PRs can be closed and branches deleted after re-locking.

You can also check the 'bump version number as appropriate' box for this. There is no version number in the code for TEA itself, that number just exists in the releases page. The tea-cli app has a version number, but it's not modified in this PR so not applicable.

@asjohnston-asf asjohnston-asf merged commit 21f1396 into asfadmin:main Dec 1, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ASFCUMULUS-845: Set additional security-related properties of session cookie

3 participants