DS-6374 Displacement: Collapse Icons when screen sizes are smaller#2408
Merged
artisticlight merged 14 commits intotestfrom Jan 15, 2026
Merged
DS-6374 Displacement: Collapse Icons when screen sizes are smaller#2408artisticlight merged 14 commits intotestfrom
artisticlight merged 14 commits intotestfrom
Conversation
Everything looks good. Need to test dark mode.
Dark mode supported and ready for testing.
…lacement-Header-Icons
minor nitpick: we should use @if @else since we're only checking a single variable (I think this was already there before this change I just noticed it in the git diff since the line got moved around) I suggest we simplify the chevron menu screen size change sanity-check (HostListener can get expensive since from my understanding the current implementation will try to query the clicked component AND every parent html element until it reaches the site's root element (https://developer.mozilla.org/en-US/docs/Web/API/Element/closest) I recommend we use Angular's animate.enter and animate.leave with css classes instead of their deprecated typescript-declared animation system, which will be removed in Angular V23. https://angular.dev/guide/animations
Bug fixes: - Remove stray xmlns attribute from container div - Add optional chaining for userAuth?.id to prevent null reference - Add i18n support for drawer-tab tooltip (COLLAPSE_PANEL, EXPAND_PANEL keys) - Add accessibility attributes to drawer-tab (aria-expanded, aria-controls, aria-label) Code quality: - Move inline styles to SCSS classes (panel-storymap-button, panel-info-button, text-adjust-storymap, text-adjust-info) - Replace magic numbers with documented SCSS variables Animation polish: - Add will-change: transform for GPU-accelerated animation - Add prefers-reduced-motion media query for accessibility
artisticlight
temporarily deployed
to
dev-andy
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a smaller screen size is used, make the info/language/story map icons collapsible so they don’t overlap