Avoid unnecessary altitude calculations to improve performance#8
Merged
asasine merged 4 commits intoasasine:mainfrom Mar 8, 2026
Merged
Avoid unnecessary altitude calculations to improve performance#8asasine merged 4 commits intoasasine:mainfrom
asasine merged 4 commits intoasasine:mainfrom
Conversation
Altitude calculations accounted for ~66% of runtime on my device. Add a temperature_pressure() method to allow the user to e.g. potentially calculate altitude using a cheaper approximation
asasine
requested changes
Mar 8, 2026
Owner
asasine
left a comment
asasine
left a comment
There was a problem hiding this comment.
Hi @RossPorter506 and thank you for the contribution! The changes look good. Could you add unit tests for the new method?
Contributor
Author
|
Sure. Is this what you had in mind? |
Owner
|
@RossPorter506 your changes have been published in v0.4.3 to https://crates.io/crates/bmp390 |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I'm using this library on an embedded device with no floating point hardware (MSP430) and after some profiling I noticed that almost 66% of the runtime of
bmp390.pressure()was coming from the (unused) altitude calculation that occurs as part of the internal call toself.measure()(17ms total, altitude took 11ms).To remedy this I moved the body of
measure()into a new public methodtemperature_pressure()that returns just the temperature and pressure, and updated the other methods to call this instead to avoid any altitude calculations that aren't required.The new method is public to allow the user to calculate altitude themselves, should they wish to use an approximation or lookup table for performance reasons.
Any comments or edits welcome.