-
Notifications
You must be signed in to change notification settings - Fork 28
Create python package, add type hints and structured types for dataset #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
- Black formatting - Move things into a `abcd` folder - Add setup.py - Convert command-line arguments to Dataclasses using simple-parsing Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com> Removed 'raw' json file from git history Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
|
Hi Fabrice, thanks for the contributions, which all look really helpful! However, it seems you have also changed the folder structure of the repo by adding an |
|
Hey @dchen-asapp , thanks for taking a look. Its not possible to create a python package without the folder structure changing slightly (at least for the code). Whats worrying about the folder structure changing, if you dont mind me asking? Are you worried it might break some of your data pipelines or automation scripts or something? |
|
I'm mostly afraid that the main training script will break since these things are often path dependent. |
Hey there, thanks for you amazing work!
I've added a few things to your repo which I'd like to offer as a contribution:
Let me know if you have any questions.
Thanks again!