Skip to content

Conversation

@lebrice
Copy link

@lebrice lebrice commented Sep 9, 2021

Hey there, thanks for you amazing work!

I've added a few things to your repo which I'd like to offer as a contribution:

  • Reorganized the source code into a python package that's easy to install
  • Added some type hints to a bunch of functions
  • Created a typed dict "schema" for the data so that the contents of the datasets can be easily understood directly in code
  • Simplified the argument parsing logic using dataclasses and simple-parsing

Let me know if you have any questions.
Thanks again!

lebrice added 18 commits July 29, 2021 16:04
- Black formatting
- Move things into a `abcd` folder
- Add setup.py
- Convert command-line arguments to Dataclasses using simple-parsing

Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>

Removed 'raw' json file from git history

Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@ghost
Copy link

ghost commented Jan 4, 2022

Hi Fabrice, thanks for the contributions, which all look really helpful! However, it seems you have also changed the folder structure of the repo by adding an abcd directory. Would it be possible to include your changes, but have the main structure remain the same? The updates themselves (such as adding better type hints) are great!

@lebrice
Copy link
Author

lebrice commented Jan 4, 2022

Hey @dchen-asapp , thanks for taking a look.

Its not possible to create a python package without the folder structure changing slightly (at least for the code).

Whats worrying about the folder structure changing, if you dont mind me asking? Are you worried it might break some of your data pipelines or automation scripts or something?

@ghost
Copy link

ghost commented Jan 4, 2022

I'm mostly afraid that the main training script will break since these things are often path dependent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant