Added isNaN - need testing #5
Conversation
| return #`isNaN ${params}`; | ||
| } | ||
|
|
||
| // if |
There was a problem hiding this comment.
kya_galat -> isNaN ? I think it can be misleading.
There was a problem hiding this comment.
How?
The isNaN() function determines whether a value is NaN (Not-a-Number) or not
I chose "kya_galat" because it returns "true" if the given value is NaN; otherwise, "false."
Do you have any suggestions?
There was a problem hiding this comment.
Can we think of something without underscore? It looks weird for a language keyword.
There was a problem hiding this comment.
It will be good if we can have list of possible suggestions because pronunciation and writing in present case can cause confusion.
btw is there any such pure urduish for such a case.
or can be like kyaNumber or kyanumber numberHae
like in English we have a short form for NaN i.e. Not-a-Number, can't it could be KnH Kya-number-Hae or something similar ?
There was a problem hiding this comment.
KnH is better though.
Anybody else?
Should I change kya_galat to KnH ?
There was a problem hiding this comment.
since we are inheriting from JavaScript, we should rather use camelCase than snake_case.
secondly isNaN => (isNotANumber()), so kyaNumberNhi kNN makes more sense than knH
k should be small so as to know its a method, not a class.
5 participants
You haven't described how to use this repo, But reading the code, I've added this isNaN functions.
This needs testing.