Skip to content

Update getTagList()#252

Draft
fe5hua wants to merge 3 commits intoasacolips-projects:mainfrom
fe5hua:patch-1
Draft

Update getTagList()#252
fe5hua wants to merge 3 commits intoasacolips-projects:mainfrom
fe5hua:patch-1

Conversation

@fe5hua
Copy link
Copy Markdown
Contributor

@fe5hua fe5hua commented Jul 25, 2024

Needed to make these changes for module defined tags to work properly. I am not using tags via the tag settings of pbta.

fe5hua added 3 commits July 25, 2024 14:29
Needed to make these changes for module defined tags to work properly.
I am not using tags via the tag settings of pbta.
took away too much.
@mclemente
Copy link
Copy Markdown
Collaborator

What is the reason for changing moduleActorTags and moduleItemTags from Objects into Strings? You're meant to format them as { [actor/item]: { all: "", [document.type]: "" } }, like this:

game.pbta.tagConfigOverride = {
  all: "",
  actor: {
    all: "",
    character: '["foo"]',
    npc: '["bar"]'
  },
  item: {
    all: "",
    gear: '["common", "rare"]'
  }
}

More importantly, how are you filtering the tags by document type if you parsing the entire object instead of just the document's type?

@mclemente mclemente marked this pull request as draft August 15, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants