feat(spots): add band-specific DX distance thresholds#315
Merged
arunderwood merged 6 commits intomainfrom Jan 8, 2026
Merged
Conversation
Different bands have vastly different propagation characteristics. A 3,000 km contact on 160m (difficult, night skip required) is exceptional, while 20m (workhorse DX band) needs 15,000 km for top scores. - Add DxThresholds record to FrequencyBand with band-specific values - Update BandActivity.normalizeDx() to use band-aware thresholds - Add frontend bandDxThresholds.ts with sync comments to Java - Add BandDxHelp component showing threshold table - Add comprehensive tests for invariants and band comparisons Closes #199
Help content now lives with its related module per project conventions. - Move BandDxHelp.tsx → cards/band-activity/BandActivityHelp.tsx - Use registerHelp() pattern instead of barrel export - Register via side-effect import in HelpModal.tsx
Research review identified inaccuracies in band descriptions: - 60m: Change "WARC; variable propagation" to "Secondary allocation; variable propagation" - 60m was allocated at 2003 WRC, not 1979 WARC - 12m: Change "WARC; similar to 15m" to "WARC; similar to 10m/15m" - 12m shares propagation characteristics with both bands Sources: Wikipedia WARC bands, HamCalc band chart, QSL.net propagation
Add test coverage for new files to satisfy delta coverage: - bandDxThresholds.ts: threshold invariants and lookup function - BandActivityHelp.tsx: registration and rendering Tests focus on business logic (threshold ordering, propagation characteristics) rather than implementation details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Different bands have vastly different propagation characteristics. This PR adds band-specific DX distance thresholds for scoring:
Changes
DxThresholdsrecord toFrequencyBandwith propagation-appropriate values for all 12 bandsBandActivity.normalizeDx()to use band-aware thresholds instead of static constantsbandDxThresholds.tswith sync comments referencing Java sourceBandDxHelpcomponent showing threshold table in help modalTest Plan
Closes #199