merge arnas branch #8
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR merges Arnas branch to introduce a comprehensive job management system with SLURM integration, Google Sheets connectivity, and real‐time monitoring via sockets. Key changes include additions to utility modules (e.g. process existence checking), new helpers for CSV/GSheet processing and configuration management, and full job submission/monitoring support.
Reviewed Changes
Copilot reviewed 20 out of 24 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| stnd/run_with_monitor/utility/local_processing_utils.py | Adds a simple process existence function using os.kill |
| stnd/run_with_monitor/utility/imports.py | Introduces lazy code importing utilities with minor naming/spelling issues |
| stnd/run_with_monitor/utility/helpers_for_tests.py | Provides test helper functions including CSV diff and dummy logger |
| stnd/run_with_monitor/test_sockets/sample_job.py | Introduces a sample socket job with SLURM submission support |
| (multiple files) | New modules for job submission, SLURM integration, configuration processing, command building, and monitoring |
Comments suppressed due to low confidence (1)
stnd/run_with_monitor/test_sockets/sample_job.py:5
- The import path uses 'stuned' instead of the expected 'stnd', which could lead to a module not found error. Please update the import path for consistency with the rest of the codebase.
from stuned.utility.helpers_for_main import prepare_wrapper_for_experiment
| return None | ||
|
|
||
|
|
||
| def is_bulitin_name(name): |
There was a problem hiding this comment.
The function name 'is_bulitin_name' appears to have a spelling mistake. Consider renaming it to 'is_builtin_name' for clarity.
| def is_bulitin_name(name): | |
| def is_builtin_name(name): |
|
|
||
| while i < total_chars and str1[i] == str2[i]: | ||
| i += 1 | ||
|
|
||
| if i == total_chars and len(str1) == len(str2): | ||
| end_pos = None |
There was a problem hiding this comment.
The variable 'end_pos' is only defined inside the if block and not in the case where a difference is found, which can lead to an undefined variable error. Consider initializing and assigning a meaningful value to 'end_pos' before the loop or handling the different cases explicitly.
| while i < total_chars and str1[i] == str2[i]: | |
| i += 1 | |
| if i == total_chars and len(str1) == len(str2): | |
| end_pos = None | |
| end_pos = i # Default to the first differing index | |
| while i < total_chars and str1[i] == str2[i]: | |
| i += 1 | |
| if i == total_chars and len(str1) == len(str2): | |
| end_pos = None # Strings are identical |
No description provided.