Add 'show' event when an object is added to a container#84
Open
pindia wants to merge 2 commits intoarturadib:masterfrom
Open
Add 'show' event when an object is added to a container#84pindia wants to merge 2 commits intoarturadib:masterfrom
pindia wants to merge 2 commits intoarturadib:masterfrom
Conversation
Owner
|
Hello Pindi, I like the idea of a I'm wondering though if there's a more robust way to make sure the element is indeed being displayed (i.e. attached to the document/DOM). For example, in your test case, neither Perhaps the way to go about this is to add a hook into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added a new event "show" that is dispatched on an object is added to a container and thus added to the DOM proper. Some use cases for this are:
Related issues: #52