Conversation
Collaborator
|
New dependencies added:
|
… fingerprint check workflow
…int check workflow
Member
Author
|
@MounirDhahri still not ready - wrapping up the upload build cached builds to main jobs, and also some extra checks. Created a tech plan here - https://www.notion.so/artsy/Build-caching-in-eigen-30acab0764a0805587f3c4232066d8d1?v=71a04384ca92465eacdd18d90342b7ad&source=copy_link |
Member
|
oki - I will continue to keep an eye on this |
Contributor
Comment on lines
+32
to
+44
| - name: Setup Ruby | ||
| uses: ./.github/actions/setup-ruby | ||
|
|
||
| - name: Setup iOS environment | ||
| uses: ./.github/actions/setup-ios-environment | ||
|
|
||
| - name: Download fonts from s3 | ||
| run: ./scripts/setup/download-fonts | ||
| shell: bash | ||
|
|
||
| - name: Download android assets | ||
| run: ./scripts/setup/download-assets-android | ||
| shell: bash |
Contributor
There was a problem hiding this comment.
do we need all these for generating the fingerprint? I am not sure just wondering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves []
Description
Tryout of s3 build caching similarly as we did in energy here, the download is way faster vs from gh pre-releases.
Will fill in some details tomorrow for this but its 97% there!
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.