chore: cleanup after fixing eigen<>echo integration#888
Merged
Conversation
gkartalis
commented
Nov 6, 2025
| { name: 'AREnableQuickLinksAnimation2', value: true }, | ||
| { name: 'AREnableRedesignedSettings', value: true }, | ||
| { name: 'ARShowOnboardingPriceRangeScreen', value: true }, | ||
| { name: 'AREnableFailingTestEcho', value: true }, |
Member
Author
There was a problem hiding this comment.
no need to keep this around since it was added and removed today for testing purposes and never made it to production
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR solves PHIRE-2492
Description
Cleans up after fixing the eigen <> echo integration.
Now echo will fail on Deploy PRs properly if enabling a feature flags breaks eigen tests.
artsy/eigen#12950
PR Checklist (tick all before merging)
Echo.json5and in CI, or I have not changed anything in that file.