Potential Vulnerability in Cloned Code #437
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agriggio
reviewed
Jan 22, 2026
| type = get4(); get4(); get4(); | ||
| wide = get4(); | ||
| high = get4(); | ||
| #ifdef LIBRAW_LIBRARY_BUILD |
Collaborator
There was a problem hiding this comment.
The ifdef doesn't make sense in our context. Probably the lines should be always enabled, but then throwing an exception might be problematic. In any case art should not be executed in security-critical situations anyway, there are probably many other potentially-exploitable vulnerabilities in the rest of the code...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a potential security vulnerability in rtengine/dcraw.cc that was cloned from https://github.com/LibRaw/LibRaw-demosaic-pack-GPL2 but did not receive the security patch.
Details:
Affected File: rtengine/dcraw.cc
Original Fix: LibRaw/LibRaw-demosaic-pack-GPL2@194f592
What this PR does:
This PR applies the same security patch that was applied to the original repository to eliminate the potential vulnerability in the cloned code.
References:
Please review and merge this PR to ensure your repository is protected against this potential vulnerability.