Split index.js file into smaller files#28
Closed
calebmchenry wants to merge 12 commits intoartlogic:masterfrom
calebmchenry:break-up-files
Closed
Split index.js file into smaller files#28calebmchenry wants to merge 12 commits intoartlogic:masterfrom calebmchenry:break-up-files
calebmchenry wants to merge 12 commits intoartlogic:masterfrom
calebmchenry:break-up-files
Conversation
td.replace is the `testdouble` function for mocking a module. Added `eslint-disable-next-line` due to needing to require a module dynamically in the test since that is how the module mocking works
Author
Author
|
Happy to reorganize if you had a different structure in mind |
Owner
|
@calebmchenry reviewing this - thanks for your patience and contribution! |
Owner
|
@calebmchenry I'm hoping to merge #29 before this one, but if that stretches on too long I'll go ahead and merge this. Thanks for your patience. |
Owner
|
@calebmchenry thanks for your patience. I'm in the process of fixing a few odds and end from adding the babel support - but if you could go ahead and start fixing the conflicts, we can get this merged pretty quick. Thanks! |
Author
|
From a quick attempt it seems to be non trivial conflicts. I will try to get to it when I can. |
Owner
|
@calebmchenry I'm sorry I haven't gotten to this yet, but I will. Do you mind if I re-open? |
Author
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
td.replace is the
testdoublefunction for mocking a module.Added
eslint-disable-next-linedue to needing to requirea module dynamically in the test since that is how the module
mocking works