Open
Conversation
✅ Deploy Preview for fastapi-filter ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #557 +/- ##
============================================
- Coverage 100.00% 83.54% -16.46%
============================================
Files 6 8 +2
Lines 193 231 +38
============================================
Hits 193 193
- Misses 0 38 +38
|
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Elasticsearch Support to FastAPI_Filter
In this pull request, I have introduced Elasticsearch support to the existing FastAPI_Filter library, which already provides search and filtering capabilities using SQLAlchemy and MongoDB. The addition of Elasticsearch support expands the range of options for users seeking efficient search functionality.
Currently, I haven't included tests and documentation for the Elasticsearch implementation. Before proceeding with these additions, I wanted to confirm whether you are interested in officially supporting Elasticsearch as part of the library.
For a practical demonstration of the Elasticsearch support, please refer to the example directory where I have provided sample code. I have also included a requirements.txt file and a docker-compose.yml file to simplify usage testing.
Please review this initial implementation and let me know if it aligns with your project's goals. If it does, I will proceed with adding comprehensive tests and documentation to ensure a seamless and well-documented contribution.