Skip to content

Conversation

@dotbit1
Copy link
Contributor

@dotbit1 dotbit1 commented Feb 27, 2025

Closes #464;
Tested with multiple new format codes.

Used https://targetare.ro/blog/schimbari-importante-la-registrul-comertului-ce-trebuie-sa-stii-despre-noul-format-al-numarului-de-ordine as a source of info.

The part about using the J, F, C ASCII values is wrong, it should be the number of the letter, etc J = 10, etc.

@arthurdejong
Copy link
Owner

Hi @dotbit1,

Could you include the numbers you tested with?

@dotbit1
Copy link
Contributor Author

dotbit1 commented Sep 2, 2025

Hi Arthur,
The code I wrote makes the existing tests fail.
The way I find 100% valid codes is: go to https://mfinante.gov.ro/ro/web/site/info-pj-selectie-nume-si-judet,
write some text that is likely to have many company names, ex. 4 letters and search,
then check each out and see if they have the new format.

Below a few examples:
J2012000750528
J2007007766403
J1992002621040
J1994000536225
J1993001036400

@arthurdejong
Copy link
Owner

Hi @dotbit1,

Sorry for taking so long to pick this up.

From my understanding the new format will be used alongside the old format. The old numbers will remain valid and old numbers will be replaced by new ones gradually. This means that old numbers will need to remain to be accepted as valid for the foreseeable future (and the existing tests shouldn't fail).

Thanks for providing the source of more numbers. I've simplified the code a bit, extended the test suite and merged it as cd94bf1. I sadly didn't find any numbers in the new format for individuals (F numbers).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support new Romanian ro_onrc format along with the old format

2 participants