Skip to content

DBC-1486 - Validate payments during webhook. #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OIOIOOOI wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

DBC-1486 - Validate payments during webhook. #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions ding_debt_easy.module
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,14 +524,6 @@ function _ding_debt_easy_callback() {
// Fetch order details form the database.
$local_record = _ding_debt_easy_get_payment_local($payment_id);

// Fetch order details form the database.
if (_ding_debt_easy_validate_payment($payment_id, $local_record)) {
$client = _ding_debt_easy_get_client();
$data = $client->fetchPayment($payment_id);
$amount = $data['orderDetails']['amount'];
_ding_debt_easy_process_payment($payment_id, $local_record, $amount);
}

// Inform user. As the payment status is handle in async web-hooks we may get
// here before the payment have been processed. So we only have to different
// message we can set.
Expand Down Expand Up @@ -590,7 +582,13 @@ function _ding_debt_easy_webhook() {

switch ($data['event']) {
case 'payment.checkout.completed':
_ding_debt_easy_update_status_local($payment_id, DING_DEBT_EASY_STATUS_COMPLETED);
// Get data needed from the payload.
$amount = $data['data']['order']['amount']['amount'];

// Fetch order details form the database.
if (_ding_debt_easy_validate_payment($payment_id, $local_record)) {
_ding_debt_easy_process_payment($payment_id, $local_record, $amount);
}
break;

case 'payment.cancel.created':
Expand Down