#78 feat(*) : improve error logging

src/Connection.php

@@ -304,7 +304,16 @@ public function _pQuery(string $query, array $params = [], array $escapes = []):
         $this->number++;
 
         if ($this->dbDriver !== null) {
-            $output = $this->dbDriver->_pQuery($query, $this->dbsafeParams($params, $escapes));
+            try {
+                $output = $this->dbDriver->_pQuery($query, $this->dbsafeParams($params, $escapes));
+            } catch (QueryException $e) {
+                $prettifiedQuery = $this->prettifyQuery($e->getQuery(), $e->getParams());
+
+                $this->logger->error($e->getMessage());
+                $this->logger->error('Query: ' . $prettifiedQuery);
+
+                throw $e;
+            }
         }
 
         if (!$output) {

src/Driver/MysqliDriver.php

@@ -15,6 +15,7 @@
 
 use Artemeon\Database\ConnectionParameters;
 use Artemeon\Database\Exception\ConnectionException;
+use Artemeon\Database\Exception\LockException;
 use Artemeon\Database\Exception\QueryException;
 use Artemeon\Database\Schema\DataType;
 use Artemeon\Database\Schema\Table;
@@ -146,6 +147,16 @@ public function _pQuery(string $query, array $params): bool
         }
 
         if ($output === false) {
+            // in case there was an error reset the statement cache so that we use a new statement
+            $name = $this->getPreparedStatementName($query);
+            if (isset($this->statementsCache[$name])) {
+                unset($this->statementsCache[$name]);
+            }
+
+            if ($statement->errno === 1213) {
+                throw new LockException('Could not execute statement: ' . $this->getError(), $query, $params);
+            }
+
             throw new QueryException('Could not execute statement: ' . $this->getError(), $query, $params);
         }
 
@@ -594,12 +605,17 @@ public function dbImport(string $fileName): bool
         return true;
     }
 
+    private function getPreparedStatementName(string $query): string
+    {
+        return md5($query);
+    }
+
     /**
      * Prepares a statement or uses an instance from the cache.
      */
     private function getPreparedStatement(string $query): false | mysqli_stmt
     {
-        $name = md5($query);
+        $name = $this->getPreparedStatementName($query);
 
         if (isset($this->statementsCache[$name])) {
             return $this->statementsCache[$name];

src/DriverInterface.php

@@ -58,6 +58,8 @@ public function insertOrUpdate(string $table, array $columns, array $values, arr
     /**
      * Sends a prepared statement to the database. All params must be represented by the "?" char.
      * The params themselves are stored using the second params using the matching order.
+     *
+     * @throws QueryException
      */
     public function _pQuery(string $query, array $params): bool;
 

src/Exception/LockException.php

@@ -0,0 +1,18 @@
+<?php
+
+/*
+ * This file is part of the Artemeon Core - Web Application Framework.
+ *
+ * (c) Artemeon <www.artemeon.de>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace Artemeon\Database\Exception;
+
+class LockException extends QueryException
+{
+}