Skip to content

fix crash when invalid pem key is decrypted #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yulius-take2 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix crash when invalid pem key is decrypted #44

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d01b0e5
patch to fix undecoded Pem
yulius-take2 Oct 15, 2021
8a22711
return empty key
yulius-take2 Oct 15, 2021
3d0163f
more invalid key handling
yulius-take2 Oct 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions src/jwt.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,8 +243,12 @@ jwt_check_sig({hmac, _} = Alg, Payload, Signature, Key) ->

jwt_check_sig({Algo, Crypto}, Payload, Signature, Pem)
when (Algo =:= rsa orelse Algo =:= ecdsa) andalso is_binary(Pem) ->
jwt_check_sig({Algo, Crypto}, Payload, Signature, pem_to_key(Pem));

case pem_to_key(Pem) of
<<"">> ->
false;
Key ->
jwt_check_sig({Algo, Crypto}, Payload, Signature, Key)
end;
jwt_check_sig({rsa, Crypto}, Payload, Signature, Key) ->
public_key:verify(Payload, Crypto, base64url:decode(Signature), Key);

Expand Down Expand Up @@ -331,10 +335,13 @@ append_claim(ClaimsSet, Key, Val) when is_map(ClaimsSet) ->
append_claim(ClaimsSet, Key, Val) -> [{ Key, Val } | ClaimsSet].

pem_to_key(Pem) ->
Decoded = case public_key:pem_decode(Pem) of
case public_key:pem_decode(Pem) of
[_, Key] ->
Key;
Key,
public_key:pem_entry_decode(Key);
[Key] ->
Key
end,
public_key:pem_entry_decode(Decoded).
Key,
public_key:pem_entry_decode(Key);
[] ->
<<"">>
end.