Mghorba/web browsers

.github/workflows/test.yml

@@ -0,0 +1,21 @@
+---
+name: Tests
+on: [ push, pull_request ]
+jobs:
+  test:
+    name: Test (Ruby ${{ matrix.ruby }})
+    runs-on: ubuntu-${{ matrix.ubuntu }}
+    strategy:
+      fail-fast: false
+      matrix:
+        ruby: [ '3.3', '3.2', '3.1', '3.0', '2.7', '2.6', '2.5', '2.4', '2.3', 'jruby-9.4' ]
+        ubuntu: [ 'latest' ]
+        include:
+          - { ruby: '2.2', ubuntu: '20.04' }
+    steps:
+      - uses: actions/checkout@v4
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+          bundler-cache: true
+      - run: bundle exec rake

README.md

@@ -1,6 +1,6 @@
 # UserAgent
 
-[![Build Status](https://travis-ci.org/gshutler/useragent.svg?branch=master)](https://travis-ci.org/gshutler/useragent)
+[![Build Status](https://github.com/gshutler/useragent/actions/workflows/test.yml/badge.svg)](https://github.com/gshutler/useragent/actions/workflows/test.yml)
 [![Gem Version](https://badge.fury.io/rb/useragent.svg)](http://badge.fury.io/rb/useragent)
 
 UserAgent is a Ruby library that parses and compares HTTP User Agents.

lib/user_agent/browsers/base.rb

@@ -32,6 +32,10 @@ def browser
         application && application.product
       end
 
+      def web_browser?
+        false
+      end
+
       def version
         application && application.version
       end
@@ -78,6 +82,10 @@ def bot?
         # list will be rejected.
         elsif detect_comment_match(/bot/i)
           true
+        # Google PageSpeed Insights adds "Chrome-Lighthouse" to the user agent
+        # https://stackoverflow.com/questions/16403295/what-is-the-name-of-the-google-pagespeed-user-agent
+        elsif detect_product("Chrome-Lighthouse")
+          true
         elsif product = application.product
           product.include?('bot')
         else

lib/user_agent/browsers/chrome.rb

@@ -19,6 +19,10 @@ def build
         webkit.version
       end
 
+      def web_browser?
+        true
+      end
+
       # Prior to Safari 3, the user agent did not include a version number
       def version
         str = if detect_product("CriOs")

lib/user_agent/browsers/edge.rb

@@ -23,6 +23,10 @@ def os
         OperatingSystems.normalize_os(os_comment)
       end
 
+      def web_browser?
+        true
+      end
+
       private
 
       def os_comment

lib/user_agent/browsers/gecko.rb

@@ -17,6 +17,10 @@ def browser
         GeckoBrowsers.detect { |browser| respond_to?(browser) } || super
       end
 
+      def web_browser?
+        true
+      end
+
       def version
         v = send(browser).version
         v.nil? ? super : v

lib/user_agent/browsers/internet_explorer.rb

@@ -20,6 +20,10 @@ def browser
         "Internet Explorer"
       end
 
+      def web_browser?
+        true
+      end
+
       def version
         str = application.comment.join('; ')[/(MSIE\s|rv:)([\d\.]+)/, 2]
         Version.new(str)

lib/user_agent/browsers/opera.rb

@@ -11,6 +11,10 @@ def browser
         'Opera'
       end
 
+      def web_browser?
+        true
+      end
+
       def version
         if mini?
           Version.new(application.comment.detect{|c| c =~ /Opera Mini/}[/Opera Mini\/([\d\.]+)/, 1]) rescue Version.new

lib/user_agent/browsers/samsung.rb

@@ -0,0 +1,31 @@
+class UserAgent
+  module Browsers
+    class Samsung < Webkit
+
+      SAMSUNG_BROWSER = 'SamsungBrowser'
+
+      def self.extend?(agent)
+        agent.detect { |useragent| useragent.product == SAMSUNG_BROWSER }
+      end
+
+      def version
+        self.detect { |useragent| useragent.product == SAMSUNG_BROWSER }.version
+      end
+
+      ##
+      # @return [Boolean]
+      #     SamsungBrowser is a mobile device
+      def mobile?
+        true
+      end
+
+      def browser
+        'Samsung Internet Browser'
+      end
+
+      def web_browser?
+        true
+      end
+    end
+  end
+end

lib/user_agent/browsers/vivaldi.rb

@@ -35,6 +35,10 @@ def platform
         end
       end
 
+      def web_browser?
+        true
+      end
+
       def webkit
         detect_product("AppleWebKit")
       end

lib/user_agent/browsers/webkit.rb

@@ -86,6 +86,10 @@ def platform
         end
       end
 
+      def web_browser?
+        true
+      end
+
       def webkit
         if product_match = detect { |useragent| useragent.product =~ WEBKIT_PRODUCT_REGEXP }
           product_match

lib/user_agent/browsers/wechat_browser.rb

@@ -9,6 +9,10 @@ def browser
         'Wechat Browser'
       end
 
+      def web_browser?
+        true
+      end
+
       def version
         micro_messenger = detect_product("MicroMessenger")
         Version.new(micro_messenger.version)

spec/browsers/acast_user_agent_spec.rb

@@ -0,0 +1,51 @@
+# frozen_string_literal: true
+
+require 'user_agent'
+
+shared_examples 'Acast' do |version, platform, os|
+  it "returns 'Acast' as its browser" do
+    expect(useragent.browser).to eq('Acast')
+  end
+
+  it "returns '#{version}' as its version" do
+    expect(useragent.version).to eq(version)
+  end
+
+  it "returns '#{platform}' as its platform" do
+    expect(useragent.platform).to eq(platform)
+  end
+
+  it "returns '#{os}' as its operating system" do
+    expect(useragent.os).to eq(os)
+  end
+
+  it { expect(useragent).to be_mobile }
+  it { expect(useragent).not_to be_desktop }
+  it { expect(useragent).not_to be_speaker }
+  it { expect(useragent).not_to be_bot }
+  it { expect(useragent).not_to be_web_browser }
+end
+
+describe "UserAgent: Acast/1.63.0 (Phone; iOS 11.2.6; iPad6,11)" do
+  let!(:useragent) { UserAgent.parse("Acast/1.63.0 (Phone; iOS 11.2.6; iPad6,11)") }
+
+  it_behaves_like 'Acast', '1.63.0', 'iPad', 'iOS 11.2.6'
+end
+
+describe "UserAgent: Acast/1.63.0 (Phone; iOS 11.2.5; iPhone9,4)" do
+  let!(:useragent) { UserAgent.parse("Acast/1.63.0 (Phone; iOS 11.2.5; iPhone9,4)") }
+
+  it_behaves_like 'Acast', '1.63.0', 'iPhone', 'iOS 11.2.5'
+end
+
+describe "UserAgent: Acast/1.42.1 (phone; android 10; Google Pixel 3 XL)" do
+  let!(:useragent) { UserAgent.parse("Acast/1.42.1 (phone; android 10; Google Pixel 3 XL)") }
+
+  it_behaves_like 'Acast', '1.42.1', 'Android', 'Android 10'
+end
+
+describe "UserAgent: Acast/1.26.0 (Linux;Android 9) ExoPlayerLib/2.2.0" do
+  let!(:useragent) { UserAgent.parse("Acast/1.26.0 (Linux;Android 9) ExoPlayerLib/2.2.0") }
+
+  it_behaves_like 'Acast', '1.26.0', 'Android', 'Android 9'
+end