-
Notifications
You must be signed in to change notification settings - Fork 0
Show completion time as metrics on the dashboard #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
|
|
||
| @pytest.fixture(scope="session") | ||
| def metrics(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually thats a good point. Given we now have better support for usign metrics.json maybe we need a toolkit helper to actually help make / populate it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That could be nice! Right now, i only add metrics from the test file, but mainly because it would need a more complex util to update metrics safely from multiple processes. It would be great if the toolkit could help with that.
| import msgs | ||
|
|
||
|
|
||
| class StuckDetector: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think this is relatively generic? (toolkit?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking about this, but probably every use-case is different enough so you cant use the same thing unless we make it complex with a lot of parameters. Might be better to have recepie-book or something with testing tricks like this.
tomonorman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
Main changes:
metrics.jsonwith the completion time for each waypoint session. This would be useful to compare policies.https://app.artefacts.com/artefacts-demos/go2-demo/job/775eed02-0657-4836-9b96-efc81697f450