Skip to content

Improve Artefacts setup #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
azazdeaz merged 5 commits into from
Nov 27, 2025
Merged

Improve Artefacts setup #12

azazdeaz merged 5 commits into from
Nov 27, 2025

Conversation

@azazdeaz
Copy link
Member

@azazdeaz azazdeaz commented Nov 26, 2025 •
edited
Loading

Main changes:

  • Add instruction to the readme for setting up an Artefacts project
  • Use ARTEFACTS_SCENARIO_UPLOAD_DIR in the tests and remove the rm -rf outputs... &&... from the artefacts.yaml
  • Ask Gemini to clean up the language on the readme (sorry, that was a lot of changes 😅 )

@azazdeaz azazdeaz requested review from fabid and tomonorman November 26, 2025 20:16
tomonorman
tomonorman reviewed Nov 27, 2025
View reviewed changes
tomonorman
tomonorman approved these changes Nov 27, 2025
View reviewed changes
Copy link
Contributor

@tomonorman tomonorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@azazdeaz azazdeaz merged commit 2ba317e into main Nov 27, 2025
1 check passed
@azazdeaz azazdeaz deleted the artefacts-setup branch November 27, 2025 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomonorman tomonorman tomonorman approved these changes

@fabid fabid Awaiting requested review from fabid

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@azazdeaz @tomonorman