Skip to content

Conversation

@miaobyte
Copy link
Contributor

@miaobyte miaobyte commented Apr 6, 2025

No description provided.

@miaobyte miaobyte requested a review from Copilot April 6, 2025 15:41
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 9 out of 18 changed files in this pull request and generated no comments.

Files not reviewed (9)
  • excuter/cpp-common/src/deepx/tensorfunc/changeshape.hpp: Language not supported
  • excuter/cpp-common/src/deepx/tf/tf.hpp: Language not supported
  • excuter/op-mem-cuda/src/client/tfs.cpp: Language not supported
  • excuter/op-mem-cuda/src/deepx/tensorfunc/changeshape_miaobyte.hpp: Language not supported
  • excuter/op-mem-cuda/src/deepx/tf/changeshape.hpp: Language not supported
  • excuter/op-mem-ompsimd/src/client/tfs.cpp: Language not supported
  • excuter/op-mem-ompsimd/src/deepx/tensorfunc/changeshape_miaobyte.hpp: Language not supported
  • excuter/op-mem-ompsimd/src/deepx/tf/changeshape.hpp: Language not supported
  • front/py/examples/2_ir/4_changeshape_reshape.dot: Language not supported
Comments suppressed due to low confidence (2)

front/py/deepx/tensor/changeshape.py:17

  • The new definitions for 'transpose' and 'transpose_' are missing the @tensor_method decorator, which could break their integration with the tensor API. Please add the missing decorator to ensure consistent behavior.
def transpose(self,*axes,out:Union[Tensor,str]=''):

front/py/deepx/nn/functional/changeshape.py:66

  • There is an inconsistency between using 't.dim' and 't.ndim' in the 'permute' function; consider using a single attribute name for clarity and to avoid potential errors.
if t.dim!=len(dimorder):

@miaobyte miaobyte merged commit f7eb067 into array2d:main Apr 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant