Skip to content

Conversation

@dmirota
Copy link

@dmirota dmirota commented Apr 1, 2020

Improvements in file reading and build

@crheckman
Copy link
Contributor

@mcguire-steve: could you please test this in linux? I'll test in Mac.

@dmirota thank you for your PR!

@mcguire-steve
Copy link
Collaborator

One thing I would like to ask is that the 'CONFIG' option to find_package be removed. By including this option, one explicitly requires the system to provide a .cmake file (such as protobufConfig.cmake), instead of allowing CMake to use any of a system module (under e.g. /usr/share/cmake-3.16/Modules), a user module (under HAL/cmake_modules), or a package config file (perhaps under /usr/lib/cmake//Config.cmake

Requiring CONFIG requires standardized names of libraries, as well as package management to provide the Config.cmake file. The addition / use of user modules allows for different flavors of systems to be supported.

To test this, I had to:

  1. Incorporate harel's feature/opencv4 branch
  2. Remove glog::glog from line 61 - unclear why this is necessary instead of the find_package constants
  3. Remove the CONFIG directive from glog and protobuf
  4. Change the caps for glog to GLog, so that the FindGLog module is called
  5. Capitalize Protobuf (line 27) to use the CMake system FindProtobuf module
  6. Disabling certain drivers that haven't yet been updated (OpenNI2, Freenect2)

@crheckman
Copy link
Contributor

@mcguire-steve have you had any more success on this? The Mac side is still taking time but I'm getting to the bottom of it.

@dmirota
Copy link
Author

dmirota commented Jun 9, 2020

@crheckman let me know if there is anything I could help explain. I'm happy to walk-through the build with you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants