perf(templates): cache parsed templates keyed by mtime#575
Closed
perf(templates): cache parsed templates keyed by mtime#575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
render/renderAndTrackcall previously read the template file from disk and re-parsed it on every invocation — wasteful in tight render loops (e.g. TUI refreshing 10×/s)ParseCacheactor insideAROTemplateServicestoringParsedTemplateobjects keyed by file pathmtime: re-parsed only when the file changes on disk; otherwise the cachedParsedTemplateis returned immediatelyrender()andrenderAndTrack()share the newloadAndParse()helper — cache is always warmed regardless of which path is takenCloses #160
Test plan
swift buildpasses cleanlyswift test)TemplateParseCacheTestscover: first render caches, mtime invalidation, path-keying across multiple templates, registered template caching,renderAndTrackcache hit