Conversation
Adds `licm` as the final post-lowering optimizer pass. Detects natural loops via back-edges and dominator-tree analysis, then hoists side-effect-free loop-invariant instructions into loop preheader blocks. Runs after GVN and branch_fold so redundancies are resolved before hoisting decisions are made. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
licmas the final post-lowering optimizer passbranch_fold— so loop exit conditions are already simplified and redundancies removed before hoisting decisions are madePipeline position
Test plan
cargo test -p herkos-core --lib— 232 tests pass (18 new licm tests)cargo clippy— cleancargo fmt --checkStack
This is PR F4 of 4 (last) in the optimizer split. Stacked on PR F3 (
pr-f3/gvn→ #37).branch_foldlocal_csegvnlicm🤖 Generated with Claude Code