feat: reproducible KMS mock #28
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of generating randm UUID and keys, base them on a counter. This
makes them reproducible when running an experiment multiple times.
To make those keys more obvious generated, set all values to `ff` except
the UUIDv4 bits and the counter at the end.
Example key IDs
ffffffff-ffff-4fff-8fff-000000000001
ffffffff-ffff-4fff-8fff-000000000002
...
Drop the no longer required google/uuid package and KeyStore.
Signed-off-by: Paul Spooren <mail@aparcar.org>
Contributor
Author
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of generating randm UUID and keys, base them on a counter. This makes them reproducible when running an experiment multiple times.
To make those keys more obvious generated, set all values to
ffexcept the UUIDv4 bits and the counter at the end.Example key IDs