Open
Conversation
Owner
|
Hey, thanks for updating the notebook with the new package name. I noticed that the notebook uses hard-coded directories to where the data and config files are installed. Could you modify the notebook so that there is variable at the top that points to the grad_june_path = Path(grad_june.__file__)then for instance we can access the config file with config_file = grad_june_path / "configs/default.yaml"and similar for the other paths. Cheers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A functional refactor of the jupyter notebook to support grad-june instead of torch-june.