Skip to content

Update jupyter notebook#7

Open
Janakan-S wants to merge 1 commit intoarnauqb:mainfrom
Janakan-S:refactor/grad-june
Open

Update jupyter notebook#7
Janakan-S wants to merge 1 commit intoarnauqb:mainfrom
Janakan-S:refactor/grad-june

Conversation

@Janakan-S
Copy link

A functional refactor of the jupyter notebook to support grad-june instead of torch-june.

@arnauqb
Copy link
Owner

arnauqb commented Jul 6, 2023

Hey, thanks for updating the notebook with the new package name. I noticed that the notebook uses hard-coded directories to where the data and config files are installed. Could you modify the notebook so that there is variable at the top that points to the grad_june installation path? Like this

grad_june_path = Path(grad_june.__file__)

then for instance we can access the config file with

config_file = grad_june_path / "configs/default.yaml"

and similar for the other paths.

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants