feat(queue): provide a way for pipeline stages to specify a backoff period (#4841)#24
Merged
christosarvanitis merged 1 commit intorelease-1.36.xfrom Aug 6, 2025
Conversation
…eriod (spinnaker#4841) * feat(queue): provide a way for pipeline stages to specify a backoff period via a new backoffPeriodMs stage configuration property. Before this, pipeline authors had no control over the backoff period. It came from either spinnaker configuration properties or implementations of RetryableTask.getDynamicBackoffPeriod. This makes it possible for pipeline authors to, for example, control the delay between attempts when webhook stages retry. The actual backoff used is the largest of: - backoffPeriodMs in the stage - tasks.global.backOffPeriod - tasks.<cloud provider>.backOffPeriod - tasks.<cloud provider>.<account name>.backOffPeriod * refactor(core): remove duplication in StageExecutionImpl since getTimeout and getBackoffPeriod were basically the same. * refactor(core): simplify StageExecutionImpl.getLongFromContext since Integer, Long and Double all extend from Number. Also, Optional.map isn't necessary since instanceof returns false when value is null. * docs(queue): update javadoc for RetryableTask.retryableBackOffPeriod to mention backoffPeriodMs stage property
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
via a new backoffPeriodMs stage configuration property. Before this, pipeline authors had no control over the backoff period. It came from either spinnaker configuration properties or implementations of RetryableTask.getDynamicBackoffPeriod.
This makes it possible for pipeline authors to, for example, control the delay between attempts when webhook stages retry. The actual backoff used is the largest of:
since getTimeout and getBackoffPeriod were basically the same.
since Integer, Long and Double all extend from Number. Also, Optional.map isn't necessary since instanceof returns false when value is null.
to mention backoffPeriodMs stage property
We prefer small, well tested pull requests.
Please refer to Contributing to Spinnaker.
When filling out a pull request, please consider the following:
Note that we are unlikely to accept pull requests that add features without prior discussion. The best way to propose a feature is to open an issue first and discuss your ideas there before implementing them.