Skip to content

Add path_to_llm_dir params to build_retriever_rag() fonction #224#225

Merged
armgilles merged 3 commits intodevfrom
custum_path_llm_dir
Apr 14, 2025
Merged

Add path_to_llm_dir params to build_retriever_rag() fonction #224#225
armgilles merged 3 commits intodevfrom
custum_path_llm_dir

Conversation

@armgilles
Copy link
Owner

Fix #224

Signed-off-by: Armand <arm.gilles@gmail.com>
@armgilles armgilles added the LLM label Apr 14, 2025
@armgilles armgilles added this to the V1.5.1 milestone Apr 14, 2025
Signed-off-by: Armand <arm.gilles@gmail.com>
Signed-off-by: Armand <arm.gilles@gmail.com>
@codecov
Copy link

codecov bot commented Apr 14, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 75.34%. Comparing base (ed0cc70) to head (94a597c).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
src/vcub_keeper/llm/crewai/rag.py 40.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #225   +/-   ##
=======================================
  Coverage   75.34%   75.34%           
=======================================
  Files          18       18           
  Lines         661      661           
=======================================
  Hits          498      498           
  Misses        163      163           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link

codspeed-hq bot commented Apr 14, 2025

CodSpeed Performance Report

Merging #225 will degrade performances by 10.06%

Comparing custum_path_llm_dir (94a597c) with dev (ed0cc70)

Summary

⚡ 2 improvements
❌ 1 (👁 1) regressions
✅ 10 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
test_benchmark_get_consecutive_no_transactions_out 2.6 ms 2.1 ms +25.53%
test_benchmark_get_transaction_all 1.9 ms 1.8 ms +5.22%
👁 test_benchmark_get_transaction_in 1.9 ms 2.1 ms -10.06%

@armgilles armgilles marked this pull request as ready for review April 14, 2025 10:18
@armgilles armgilles merged commit 24402bd into dev Apr 14, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant