refactor: conditionally hide custom image button when manufacturer is selected #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… selected Improve UI flow by making the custom image button mutually exclusive with the manufacturer selection path. This creates a clearer distinction between the two image selection workflows: - Standard path: Manufacturer → Board → OS Image - Custom path: Direct custom image selection The custom image button is now hidden when a manufacturer is selected, and reappears when the manufacturer is deselected. This change prepares the UI for future integration of board pre-setup configuration phases. This modification ensures better user experience by preventing conflicting selection states and provides a cleaner interface for the upcoming board pre-setup features planned for future releases.
SuperKali
added
enhancement
🧪 Test BuildsVersion:
ℹ️ About these builds
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the custom image button visibility logic to create a cleaner UI flow by making the manufacturer selection and custom image paths mutually exclusive. When a manufacturer is selected, the custom image button is now hidden, and reappears when the manufacturer is deselected.
Motivation
The current UI shows both selection paths simultaneously, which can lead to user confusion and conflicting states. This change improves the user experience by:
Changes
src/components/layout/HomePage.tsx!selectedManufacturer)UI Behavior
Before
After
selectedManufactureris null)Screenshots