Skip to content

Conversation

@HeyMeco
Copy link

@HeyMeco HeyMeco commented Jan 12, 2026

Description

This PR does two things:

  1. Add option to only download the selected image to disk

    • Toggle with checkbox for decompression option
    • Localisation for this feature in all languages supported by imager
    CleanShot 2026-01-12 at 20 30 07@2x
  2. Fix SHA verification for armbian/os trunk images on GitHub by utilising the GitHub API which offers SHA of the artifact

    • Caches fetched api response
    • Before SHA comparison fails as there is no .sha file on dl.armbian.com for the requested Armbian-trunk...

All features have been implemented with Claude Opus 4.5 as a guide and validated in use. Please review carefully to make sure there is no regression

@HeyMeco HeyMeco requested a review from SuperKali January 12, 2026 19:40
@SuperKali
Copy link
Member

Hi @HeyMeco,

I like the idea, but as it currently stands, it might be a bit confusing for users. I think it would be more appropriate to add a toggle in the settings. The download option should also be placed in something separate rather than directly within the device selector, which in my opinion doesn't quite fit—users should be selecting their device there, not downloading images. Of course, it doesn't make sense to add another box on the homepage, but if you have any ideas on where to place that download button in a way that's also aesthetically pleasing, please let me know. In the meantime, if I come up with any ideas, I'll share them here.

Thank you for your contribution to the project!

@SuperKali
Copy link
Member

Fix SHA verification for armbian/os trunk images on GitHub by utilising the GitHub API which offers SHA of the artifact

  • Caches fetched api response
  • Before SHA comparison fails as there is no .sha file on dl.armbian.com for the requested Armbian-trunk...

Can you show me examples where it actually fails?

@igorpecovnik
Copy link
Member

Fix SHA verification for armbian/os trunk images on GitHub by utilising the GitHub API which offers SHA of the artifact

I think we need to harden this on CI side so that it won't happen that images are without signatures / SHA artifacts. I have addressed this problem last week and it should be o.k. Only nightly / community images are served via GH so relying on API here, well, ok, but not solving for all.

For "download only" in case there is no device to flash. I don't know - i would enable this if developer mode is enabled. IMO normal user should be limited here: "if you don't have a device to flash -> stop & insert device to flash."

@SuperKali SuperKali force-pushed the main branch 2 times, most recently from bb9e983 to a0e7add Compare January 23, 2026 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants