Lookout: wrap ErrNotFound in GetJobSpec not-found error

[mauriceyap]

Replace github.com/pkg/errors with stdlib fmt.Errorf and wrap ErrNotFound so callers can use errors.Is to distinguish not-found from other errors.

[greptile-apps]

Greptile Summary

This PR modernises the error handling in GetJobSpec: it drops the github.com/pkg/errors dependency in favour of the stdlib, adopts errors.Is for the pgx.ErrNoRows sentinel check, and wraps the package-level ErrNotFound sentinel into the returned error so callers can reliably use errors.Is(err, repository.ErrNotFound) to distinguish not-found from other database errors.

• getjobspec.go: imports swapped (github.com/pkg/errors → "errors" + "fmt"), equality check upgraded to errors.Is(err, pgx.ErrNoRows), error now wraps ErrNotFound via %w — matches the pattern in getjoberror.go and getjobrunerror.go.
• getjobspec_test.go: test strengthened from assert.Error to assert.ErrorIs(t, err, ErrNotFound), correctly validating the new sentinel wrapping.
• No logic regressions; the pgx.ErrNoRows guard and the pass-through return nil, err for all other DB errors are both preserved.

Confidence Score: 5/5

• This PR is safe to merge — it is a small, focused, and correct error-handling improvement with no logic regressions.
• The change is minimal: two files, a dependency swap from github.com/pkg/errors to stdlib, an idiomatic errors.Is upgrade, and sentinel wrapping. The pgx.ErrNoRows guard and pass-through for other errors are both preserved. The implementation is consistent with the already-reviewed sibling files (getjoberror.go, getjobrunerror.go), and the test assertion is correctly strengthened to validate the new behaviour. No other behaviour is affected.
• No files require special attention.

Important Files Changed

Filename	Overview
internal/lookout/repository/getjobspec.go	Replaces github.com/pkg/errors with stdlib errors/fmt, switches to idiomatic errors.Is(err, pgx.ErrNoRows), and wraps ErrNotFound so callers can use errors.Is — consistent with sibling files getjoberror.go and getjobrunerror.go.
internal/lookout/repository/getjobspec_test.go	Updates the not-found test assertion from the weaker assert.Error to assert.ErrorIs(t, err, ErrNotFound), correctly verifying the sentinel wrapping introduced in the main file.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[GetJobSpec called] --> B[QueryRow: SELECT job_spec\nWHERE job_id = $1]
    B --> C{err != nil?}
    C -- No --> D[Decompress rawBytes]
    D --> E{decompress err?}
    E -- No --> F[proto.Unmarshal]
    F --> G{unmarshal err?}
    G -- No --> H[Return *api.Job]
    G -- Yes --> I[Return unmarshal error]
    E -- Yes --> J[Return decompress error]
    C -- Yes --> K{errors.Is\nerr, pgx.ErrNoRows?}
    K -- Yes --> L["Return nil,\nfmt.Errorf('...not found: %w', ErrNotFound)"]
    K -- No --> M[Return nil, err\n other DB error]

Loading

_{Reviews (7): Last reviewed commit: "Lookout: wrap ErrNotFound in GetJobSpec ..." | Re-trigger Greptile}

[mauriceyap]

@Mergifyio refresh

[mergify]

refresh

✅ Pull request refreshed

[mauriceyap]

@Mergifyio rebase

[mauriceyap]

@Mergifyio refresh

[mauriceyap]

https://github.com/Mergifyio refresh

[mergify]

refresh

✅ Pull request refreshed

[pavlovic-ivan]

https://github.com/Mergifyio refresh

[mergify]

refresh

☑️ Command disallowed due to command restrictions in the Mergify configuration.

Details

• any of:
  • sender = {{author}}
  • sender-permission >= write

[mauriceyap]

@Mergifyio refresh

[mergify]

refresh

✅ Pull request refreshed

[mauriceyap]

@Mergifyio refresh

[mergify]

refresh

✅ Pull request refreshed