Ask to propagate OT info to all Pokémon when trainer identity changes#248
Draft
Ask to propagate OT info to all Pokémon when trainer identity changes#248
Conversation
Co-authored-by: arleypadua <17691875+arleypadua@users.noreply.github.com> Agent-Logs-Url: https://github.com/arleypadua/PKHeX.Everywhere/sessions/cec29d4d-2a32-49ae-845b-70b8dd3f1b36
Co-authored-by: arleypadua <17691875+arleypadua@users.noreply.github.com> Agent-Logs-Url: https://github.com/arleypadua/PKHeX.Everywhere/sessions/32495990-6791-46a6-bdc3-e2d12a8ccd34
…Pokémon OT Co-authored-by: arleypadua <17691875+arleypadua@users.noreply.github.com> Agent-Logs-Url: https://github.com/arleypadua/PKHeX.Everywhere/sessions/32495990-6791-46a6-bdc3-e2d12a8ccd34
…ignore Co-authored-by: arleypadua <17691875+arleypadua@users.noreply.github.com> Agent-Logs-Url: https://github.com/arleypadua/PKHeX.Everywhere/sessions/32495990-6791-46a6-bdc3-e2d12a8ccd34
Copilot created this pull request from a session on behalf of
arleypadua
March 23, 2026 22:51
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing trainer Name/TID/SID on the Home page silently updated only the save file header — every existing Pokémon retained its old Original Trainer data. This adds a confirmation modal so the user can choose whether to bulk-apply the new identity to all Pokémon.
PKHeX.Facade —
Trainer.csPokemonInPartyCount/PokemonInBoxCount— non-empty slot counts used in the modal messageApplyOwnerToAll()— setsOwner.Name/TID/SIDon every non-empty party + box Pokémon to the current trainer values, then callsCommit()PKHeX.Web —
Home.razorHandleNameChanged/HandleTIDChanged/HandleSIDChangednow defer the write: they store the mutation in_pendingTrainerChangeand open the modal instead of applying immediatelyApplyOwnerToAll()PKHeX.Facade.Tests —
TrainerTests.csApplyOwnerToAll_ShouldUpdateAllPokemon— sets trainer identity, callsApplyOwnerToAll, save/reloads, and asserts every non-empty Pokémon carries the new Name, TID, and SID (p.Id.TID/SIDrather thanp.Owner.TID/SIDbecauseOwner.TIDgetter usesTrainerTID7, which is a Gen 7-style derived value and not symmetric with theDisplayTIDsetter for Gen 4 saves)