Added options argument for allowing ignoring properties like __ko_mapping__ and including computed values#11
Open
adamtal3 wants to merge 4 commits intoarj03:masterfrom
Open
Added options argument for allowing ignoring properties like __ko_mapping__ and including computed values#11adamtal3 wants to merge 4 commits intoarj03:masterfrom
adamtal3 wants to merge 4 commits intoarj03:masterfrom
Conversation
Owner
|
Looks good, could you add some tests? |
|
Works great on my code! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let the user choose which properties to include and which to ignore.
I had a performance issue with ko.mapping.toJS and replaced it with ko.wrap.toJS which lacked my most basic needs from the conversion. I updated it as little as possible to keep it fast but also allow the user to control the conversion.
Plus, I added a package.json, bower.json and updated nupkg files after bumping the version to 1.0.2.