AVGR & NK Npcs, Huffing, and misc changes/additions#349
AVGR & NK Npcs, Huffing, and misc changes/additions#349Demadunk wants to merge 1 commit intoaristotlepenguin:masterfrom
Conversation
Demadunk
commented
Dec 22, 2023
Demadunk
commented
- Added Angry Video Game Rowdy and Nostalgia Killer from MischiefNight's winning entry from the NPC contest (Overdue)
- Added Spraycan variant of paintthinner huffing, lasts only for 3 minutes.
- Rebalanced Diamond Armor's cost due to no longer being a guaranteed 15 freshness.
- Fixed "Slimeoid is now your Slimeoid" error when unfreezing your slimeoids.
- Changed a promotional Slimernalia fish to something unique due to being almost exactly another fish
- added 3 cosmetics, only available by Bazaar.
Fuck this shitty program
| user_data = EwUser(member = cmd.message.author) | ||
| status = user_data.getStatusEffects() | ||
| item_sought = bknd_item.find_item(item_search=ewcfg.weapon_id_thinnerbomb, id_user=cmd.message.author.id, id_server=cmd.guild.id, item_type_filter=ewcfg.it_weapon) | ||
| item_sought = bknd_item.find_item(item_search=ewcfg.weapon_id_thinnerbomb, id_user=cmd.message.author.id, id_server=cmd.guild.id, item_type_filter=ewcfg.it_weapon) or bknd_item.find_item(item_search=ewcfg.weapon_id_spraycan, id_user=cmd.message.author.id, id_server=cmd.guild.id, item_type_filter=ewcfg.it_weapon) |
There was a problem hiding this comment.
This could be made cleaner and more functional by instead having the player specify an item to search. It'd allow the player to choose to huff either a spraycan or a thinnerbomb, even if both are in the inventory.
| EwCosmeticItem( | ||
| id_cosmetic = "kilmisterhat", | ||
| str_name = "Kilmister Hat", | ||
| str_desc = "A hat that screams of pure toughness, a modified cowboy hat with a strap that comes without any folded up edges. The strap has many spades present.", |
There was a problem hiding this comment.
Two independent clauses joined by a comma and nothing else
| EwCosmeticItem( | ||
| id_cosmetic = "stripedraidermask", | ||
| str_name = "Striped Raider Mask", | ||
| str_desc = "It's a rare ornate mask of tribal origins. It's made of some metallic material and wooden stripes built into the headgear itself. The stripes seems to be aiming right into the nose with the top of the mask having stripes going all over the place. What a steal!", |
There was a problem hiding this comment.
Combine the first two sentences by removing the second "It's" and replacing it with a comma.
| id_cosmetic = "shelledraidermask", | ||
| str_name = "Shelled Raider Mask", | ||
| str_desc = "It's some sort of rare tribal mask. It's made out of various seeds built into the headgear and some patterns are found leading from the nose into the mouthpiece. Even has some leather like flabs on the sides.", | ||
| rarity = "patrician", |
There was a problem hiding this comment.
These all probably shouldn't be Patrician. They're very common and cheap, and should instead be Plebeian.
| EwCosmeticItem( | ||
| id_cosmetic = "shelledraidermask", | ||
| str_name = "Shelled Raider Mask", | ||
| str_desc = "It's some sort of rare tribal mask. It's made out of various seeds built into the headgear and some patterns are found leading from the nose into the mouthpiece. Even has some leather like flabs on the sides.", |
There was a problem hiding this comment.
"It's some sort of rare tribal mask, made out of various seeds built into the headgear. Some patterns are found leading from the nose into the mouthpiece, and it even has some leather-like flabs on the sides."
Weird joining of clauses, "leather-like" is used as an adjective and thus needs a hyphen, and the last sentence doesn't start correctly.
| catch_time = None, | ||
| catch_weather = None, | ||
| str_desc = "An opportunistic predator, it waits until their prey has tired out and unable to act. Watch out for those hook shaped spines!", | ||
| str_desc = "Known to be poisonous enough to where it poisons itself. It's dead, yet it lives to spite that fact.", |
There was a problem hiding this comment.
Did you mean "despite" or "to spite"?
| ], | ||
| ingredients={ | ||
| ewcfg.item_id_minecraftdiamond: 4, | ||
| ewcfg.item_id_minecraftdiamond: 1, |
| str_describe="They are gassed up on paint thinner.", | ||
| str_describe_self="You are gassed up on paint thinner." | ||
| str_describe="They are gassed up on paint fumes.", | ||
| str_describe_self="You are gassed up on paint fumes." |
There was a problem hiding this comment.
I'm gonna go brain mode and, as a suggestion, say this should be "organic vapors". Makes more sense, because paint thinner doesn't really release "paint fumes" per-se.
| slimeoid_name = "Bold Lee Flea", | ||
| starting_statuses = ['9leveltrainer', ewcfg.status_enemy_trainer_id], | ||
| condition=lambda user_data, enemy_data: True if (user_data.faction == 'rowdys' and user_data.life_state == ewcfg.life_state_enlisted) or ewcfg.status_enemy_hostile_id in enemy_data.getStatusEffects() else False | ||
| ), |
There was a problem hiding this comment.
I think these are good for right now, though an NPC rework is probably coming.
3 participants
