Skip to content

fix for issue #290 - allow passing key and cert file to the connect() #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dlyssenko merged 4 commits into from
Dec 16, 2024
Merged

fix for issue #290 - allow passing key and cert file to the connect() #311

dlyssenko merged 4 commits into from
Dec 16, 2024

Conversation

@dlyssenko
Copy link
Contributor

@dlyssenko dlyssenko commented Dec 14, 2024

  1. fixed issue SSLContext.wrap_socket() throws a TypeError when attempting to connect to a switch using transport: https_certs #290 - now private key and certificate can be passed as parameters to the pyeapi connect() method when https_certs transport is used
  2. added system test to ensure transport https_certs works

@dlyssenko
Update test_client.py
cafb83d 
made backward compatible syntax with py3.7 for `with` statement to pass flake check
@dlyssenko
Update test_client.py
7afc55c 
added missing space
@dlyssenko
Update test_client.py
594712c 
moved assert under the loop, where it belongs
@dlyssenko dlyssenko merged commit c8427cc into arista-eosplus:develop Dec 16, 2024
10 checks passed
@dlyssenko dlyssenko mentioned this pull request Dec 16, 2024
Closed
@dlyssenko dlyssenko mentioned this pull request Mar 19, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stefanos-sagkriotis-arista stefanos-sagkriotis-arista stefanos-sagkriotis-arista approved these changes

@mharista mharista Awaiting requested review from mharista

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dlyssenko @stefanos-sagkriotis-arista