Open
Conversation
Fixed issue when tex.name is only an image extension. Now combines texture name with material name if texture name is 4 characters or less, and starts with a '.'
ideoservo
approved these changes
Apr 22, 2021
Owner
|
@MrGaribaldi I also couldn't merge your PR at the time because I have moved on with a few more changes and commits on my end already. It's always nice to create the PR for the most active branch, here develop. Now since I have pulled all my changes to the main branch, would you like to resolve the current conflicts here and make a fresh PR?
I have one more question related to the logic you have used. But first, let us resolve the current conflict and from there we can move ahead. Also, please provide me with a sample file to reproduce the bug you have faced (if possible), that would be super nice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sketchup api doesn't ensure there is a valid filename in texture.name, sometimes it only contains the filename extension.
Blender handles this fine, except when such materials are exported to other formats like fbx, then the missing filenames creates trouble.
I've solved this issue by checking if the texture.name starts with a '.' and the length is less than 5 characters. In this case we know that there will only be an image extension in the filename, and should combine it with the material name.
This simple fix ensures you can export the imported model.