-
Notifications
You must be signed in to change notification settings - Fork 4
test(medium): Refactor useWorkoutSession for Zones, Auto-Pause, and Throttling #7671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feat/workout-session-persistence-7679997534681558919
Are you sure you want to change the base?
Conversation
…ptimize UX - Implement `timeInZones` state and logic in `useWorkoutSession` to restore regression. - Add `lastActiveTime` tracking and auto-pause logic on session hydration to prevent duration jumps. - Reduce UI update throttling from 5000ms to 1000ms for smoother experience. - Optimize `startWorkout` stability using `useRef` for `totalCalories`. - Update unit tests to cover new functionality and fix mock discrepancies. Co-authored-by: arii <342438+arii@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
📋 Quality Gate Results
❌ Lint Failure Details❌ Infrastructure Test Failure Details❌ Unit Test Failure Details❌ Component Test Failure Details❌ Visual Test Failure Details❌ Performance Test Failure Details
|
I have addressed the linting and formatting issues in |
Description
This PR addresses regressions and UX issues in
useWorkoutSession:timeInZonescalculation and persistence within the hook state to ensure analytics features work correctly in real-time.startWorkoutcallback to prevent unnecessary re-renders in consumer components (ConnectPage).useWorkoutSession.test.tsto verify these changes.Fixes #
Change Type: 🐛 Bug fix (non-breaking change fixing an issue)
PR Scope Checklist
This checklist is mandatory for all PRs.
Impact Assessment
Original PR Body
This PR addresses regressions and UX issues in
useWorkoutSession:timeInZonescalculation and persistence within the hook state to ensure analytics features work correctly in real-time.startWorkoutcallback to prevent unnecessary re-renders in consumer components (ConnectPage).useWorkoutSession.test.tsto verify these changes.PR created automatically by Jules for task 8015467242927168109 started by @arii