test(medium): Refactor Spotify Polling Architecture #7654
Conversation
- Introduce `SpotifyManagerContext` to decouple managers from `SpotifyPolling`. - Managers now access SDK via `context.getSdk()`. - Fix state staleness in `SpotifyPlayerManager`. - Remove `_test_` block from `SpotifyPolling`. - Move `SafeSpotifyApi` type to `types/spotify.ts`. - Update unit tests. Co-authored-by: arii <342438+arii@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
github-actions
bot
changed the title
📋 Quality Gate Results
❌ Build Failure Details❌ Infrastructure Test Failure Details❌ Unit Test Failure Details❌ Component Test Failure Details❌ Visual Test Failure Details❌ Performance Test Failure Details
|
I have fixed the build failure. The issue was a type mismatch in the fallback stub for |
1 participant
Description
Refactor the Spotify polling architecture to improve robustness and testability.
Key changes:
SpotifyManagerContextinterface to provide a stable way forSpotifyPlayerManagerandSpotifyDeviceManagerto access the Spotify SDK and shared state. This resolves the "fragile SDK propagation" issue where managers could hold references to stale SDK instances.SpotifyPlayerManager.refreshPlaybackStateto fetch the new playback state before capturing the current local state, ensuring comparisons are made against the most recent data and preventing race conditions._test_block and associated helper methods fromSpotifyPollingin favor of more robust integration-style testing using public methods and mocks.SafeSpotifyApitype definition totypes/spotify.tsto resolve circular dependency issues between services and types.SpotifyPolling,SpotifyPlayerManager, andSpotifyDeviceManagerto align with the new architecture and constructor signatures.Fixes # (issue)
Change Type: 🏗️ Refactoring (code change that neither fixes bug nor adds feature)
PR Scope Checklist
This checklist is mandatory for all PRs.
Impact Assessment
Original PR Body
Refactor the Spotify polling architecture to improve robustness and testability.
Key changes:
SpotifyManagerContextinterface to provide a stable way forSpotifyPlayerManagerandSpotifyDeviceManagerto access the Spotify SDK and shared state. This resolves the "fragile SDK propagation" issue where managers could hold references to stale SDK instances.SpotifyPlayerManager.refreshPlaybackStateto fetch the new playback state before capturing the current local state, ensuring comparisons are made against the most recent data and preventing race conditions._test_block and associated helper methods fromSpotifyPollingin favor of more robust integration-style testing using public methods and mocks.SafeSpotifyApitype definition totypes/spotify.tsto resolve circular dependency issues between services and types.SpotifyPolling,SpotifyPlayerManager, andSpotifyDeviceManagerto align with the new architecture and constructor signatures.PR created automatically by Jules for task 2752464580658856891 started by @arii