Skip to content

chore: Bump FluentAssertions from 6.12.2 to 8.9.0 #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arielbvergara merged 2 commits into from
Apr 12, 2026
Merged

chore: Bump FluentAssertions from 6.12.2 to 8.9.0 #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b9b197
chore: Bump FluentAssertions from 6.12.2 to 8.9.0
dependabot[bot] Mar 23, 2026
62fad72
fix: update FluentAssertions method names for v8.x compatibility
arielbvergara Apr 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lifehacking/Tests/Application.Tests/Application.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<PackageReference Include="Moq" Version="4.20.72" />
<PackageReference Include="xunit" Version="2.9.3" />
<PackageReference Include="xunit.runner.visualstudio" Version="3.1.5" />
<PackageReference Include="FluentAssertions" Version="6.12.2" />
<PackageReference Include="FluentAssertions" Version="8.9.0" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\..\Application\Application.csproj" />
Expand Down
38 changes: 19 additions & 19 deletions lifehacking/Tests/Application.Tests/UseCases/Dashboard/GetDashboardUseCaseTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,23 +97,23 @@ public async Task ExecuteAsync_ShouldReturnDashboardStatistics_WhenDataExists()

// Users assertions - verify totals and that new properties exist
result.Value!.Users.Total.Should().Be(8);
result.Value.Users.ThisDay.Should().BeGreaterOrEqualTo(1);
result.Value.Users.LastDay.Should().BeGreaterOrEqualTo(0);
result.Value.Users.ThisWeek.Should().BeGreaterOrEqualTo(1);
result.Value.Users.LastWeek.Should().BeGreaterOrEqualTo(0);
result.Value.Users.ThisMonth.Should().BeGreaterOrEqualTo(1);
result.Value.Users.LastMonth.Should().BeGreaterOrEqualTo(0);
result.Value.Users.ThisYear.Should().BeGreaterOrEqualTo(1);
result.Value.Users.ThisDay.Should().BeGreaterThanOrEqualTo(1);
result.Value.Users.LastDay.Should().BeGreaterThanOrEqualTo(0);
result.Value.Users.ThisWeek.Should().BeGreaterThanOrEqualTo(1);
result.Value.Users.LastWeek.Should().BeGreaterThanOrEqualTo(0);
result.Value.Users.ThisMonth.Should().BeGreaterThanOrEqualTo(1);
result.Value.Users.LastMonth.Should().BeGreaterThanOrEqualTo(0);
result.Value.Users.ThisYear.Should().BeGreaterThanOrEqualTo(1);
result.Value.Users.LastYear.Should().Be(1);

// Categories assertions
result.Value.Categories.Total.Should().Be(3);
result.Value.Categories.ThisMonth.Should().BeGreaterOrEqualTo(1);
result.Value.Categories.ThisMonth.Should().BeGreaterThanOrEqualTo(1);

// Tips assertions
result.Value.Tips.Total.Should().Be(5);
result.Value.Tips.ThisDay.Should().BeGreaterOrEqualTo(1);
result.Value.Tips.ThisMonth.Should().BeGreaterOrEqualTo(1);
result.Value.Tips.ThisDay.Should().BeGreaterThanOrEqualTo(1);
result.Value.Tips.ThisMonth.Should().BeGreaterThanOrEqualTo(1);
}

[Fact]
Expand Down Expand Up @@ -299,21 +299,21 @@ public async Task ExecuteAsync_ShouldIncludeAllTimePeriodsInResponse_WhenCalled(
result.Value!.Users.Total.Should().Be(3);

// Verify all time period properties are present and have valid values (>= 0)
result.Value.Users.ThisDay.Should().BeGreaterOrEqualTo(0);
result.Value.Users.LastDay.Should().BeGreaterOrEqualTo(0);
result.Value.Users.ThisWeek.Should().BeGreaterOrEqualTo(0);
result.Value.Users.LastWeek.Should().BeGreaterOrEqualTo(0);
result.Value.Users.ThisMonth.Should().BeGreaterOrEqualTo(0);
result.Value.Users.LastMonth.Should().BeGreaterOrEqualTo(0);
result.Value.Users.ThisYear.Should().BeGreaterOrEqualTo(0);
result.Value.Users.LastYear.Should().BeGreaterOrEqualTo(0);
result.Value.Users.ThisDay.Should().BeGreaterThanOrEqualTo(0);
result.Value.Users.LastDay.Should().BeGreaterThanOrEqualTo(0);
result.Value.Users.ThisWeek.Should().BeGreaterThanOrEqualTo(0);
result.Value.Users.LastWeek.Should().BeGreaterThanOrEqualTo(0);
result.Value.Users.ThisMonth.Should().BeGreaterThanOrEqualTo(0);
result.Value.Users.LastMonth.Should().BeGreaterThanOrEqualTo(0);
result.Value.Users.ThisYear.Should().BeGreaterThanOrEqualTo(0);
result.Value.Users.LastYear.Should().BeGreaterThanOrEqualTo(0);

// Verify the sum of all periods doesn't exceed total
var allPeriods = result.Value.Users.ThisDay + result.Value.Users.LastDay +
result.Value.Users.ThisWeek + result.Value.Users.LastWeek +
result.Value.Users.ThisMonth + result.Value.Users.LastMonth +
result.Value.Users.ThisYear + result.Value.Users.LastYear;
allPeriods.Should().BeGreaterOrEqualTo(0, "all period counts should be non-negative");
allPeriods.Should().BeGreaterThanOrEqualTo(0, "all period counts should be non-negative");
}

[Fact]
Expand Down
4 changes: 2 additions & 2 deletions lifehacking/Tests/Application.Tests/Validation/FileValidationHelperTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ public void SanitizeFileName_ShouldTruncateToMaxLength_WhenFileNameIsTooLong()
var result = FileValidationHelper.SanitizeFileName(longFileName);

// Assert
result.Length.Should().BeLessOrEqualTo(255, "filename should be truncated to 255 characters");
result.Length.Should().BeLessThanOrEqualTo(255, "filename should be truncated to 255 characters");
}

[Fact]
Expand All @@ -263,7 +263,7 @@ public void SanitizeFileName_ShouldPreserveExtension_WhenTruncating()

// Assert
result.Should().EndWith(".jpg", "file extension should be preserved when truncating");
result.Length.Should().BeLessOrEqualTo(255);
result.Length.Should().BeLessThanOrEqualTo(255);
}

[Fact]
Expand Down