Retain the old return code when executing the bash_prompt changes.#133
Open
gerph wants to merge 1 commit intoarialdomartini:masterfrom
Open
Retain the old return code when executing the bash_prompt changes.#133gerph wants to merge 1 commit intoarialdomartini:masterfrom
gerph wants to merge 1 commit intoarialdomartini:masterfrom
Conversation
The 'bash_prompt' function was not preserving the return code between calls to it. If other PROMPT_COMMAND executions were to rely on the return code - say, to change the value of a variable that would be substituted into the PS1 value to indicate the return code - this would be broken, causing such functions to break. This change preserves the return code such that the subsequent prompt command executions can take advantage of the value of the prior executed commands return.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'bash_prompt' function was not preserving the return code between
calls to it. If other PROMPT_COMMAND executions were to rely on the
return code - say, to change the value of a variable that would be
substituted into the PS1 value to indicate the return code - this
would be broken, causing such functions to break.
This change preserves the return code such that the subsequent prompt
command executions can take advantage of the value of the prior
executed commands return.