Skip to content

Add topoapi check + cleanup netrc check#47

Draft
sssangha wants to merge 1 commit intomasterfrom
sss_topoapi
Draft

Add topoapi check + cleanup netrc check#47
sssangha wants to merge 1 commit intomasterfrom
sss_topoapi

Conversation

@sssangha
Copy link
Collaborator

@sssangha sssangha commented Aug 3, 2022

Add topoapi check + cleanup .netrc checks and move all to prep stage(s) at top of notebook.

If a given file doesn't exist, and explicit warning is passed, plus a prompt for users to enter their credentials.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@sssangha sssangha requested review from bbuzzanga and ehavazli August 3, 2022 05:40
@sssangha sssangha marked this pull request as draft August 3, 2022 07:54
@bbuzzanga
Copy link
Collaborator

ReviewNB is not working correctly. Did you just add the block at the top for inputting netrc / opentopo credentials?

@ehavazli
Copy link
Collaborator

ehavazli commented Aug 3, 2022

@sssangha when the notebook asks for username and password both are visible as we enter them. Is this something we may want to avoid? It isn't really that big of a deal probably but just wanted to point out.

Also when committing notebooks, it may be a good idea to "clear outputs" which would shrink the size of the notebook and make it faster to checkout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants