Skip to content

build: refactor the clang-tidy github action #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tomghuang merged 1 commit into from
May 24, 2025
Merged

build: refactor the clang-tidy github action #112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 21 additions & 14 deletions .github/workflows/clang-tidy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Run clang-tidy
name: Clang-Tidy

on:
pull_request:
Expand All @@ -9,32 +9,39 @@ on:
jobs:
build:
name: Run clang-tidy
runs-on: ubuntu-24.04
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Checkout code
uses: actions/checkout@v4

- name: Install clang-tidy
run: sudo apt-get install -y clang-tidy

- name: Run CMake to generate the compilation database
run: |
mkdir build
cmake -B build -DARGTABLE3_ENABLE_TESTS=0 -DARGTABLE3_ENABLE_EXAMPLES=0 -DCMAKE_EXPORT_COMPILE_COMMANDS=1 .
run: cmake -B build -DARGTABLE3_ENABLE_TESTS=0 -DARGTABLE3_ENABLE_EXAMPLES=0 -DCMAKE_EXPORT_COMPILE_COMMANDS=1 .

- name: Run clang-tidy on files in src/
run: |
clang-tidy -p build/compile_commands.json src/*.c | tee warnings.txt
run: clang-tidy -p build/compile_commands.json src/*.c | tee warnings.txt

- name: Convert absolute paths to relative ones
run: |
sed -i "s|${GITHUB_WORKSPACE}/||g" warnings.txt
run: sed -i "s|${GITHUB_WORKSPACE}/||g" warnings.txt

- name: Download clang-tidy-sarif
run: |
curl -sSL https://github.com/psastras/sarif-rs/releases/download/clang-tidy-sarif-v0.3.3/clang-tidy-sarif-x86_64-unknown-linux-gnu -o clang-tidy-sarif
chmod +x clang-tidy-sarif

- name: Convert clang-tidy warnings to SARIF
run: |
./clang-tidy-sarif -o results.sarif warnings.txt
- uses: actions/upload-artifact@v4
run: ./clang-tidy-sarif -o results.sarif warnings.txt

- name: Upload warnings and SARIF file
uses: actions/upload-artifact@v4
with:
path: |
warnings.txt
results.sarif
- name: Upload SARIF file

- name: Upload SARIF file to GitHub
uses: github/codeql-action/upload-sarif@v3
with:
sarif_file: results.sarif
Expand Down