Fix purge_paths in sync-r2.sh by removing unnecessary leading slashes
#178
Conversation
marcocastignoli
changed the title
| purge_paths+=("/${path}") | ||
| done < <(find . \( -wholename '*/list.*' -o -wholename '*/*-latest' -o -wholename '*/*-latest.*' \) | cut --characters 2-) | ||
| purge_paths+=("${path}") | ||
| done < <(find . \( -wholename '*/list.*' -o -wholename '*/*-latest' -o -wholename '*/*-latest.*' \) | cut -c 2-) |
There was a problem hiding this comment.
Why the change to -c is needed? I see the commit message: "Correct cut command in sync-r2.sh" but I don't know for what reason you cannot use --characters. The man page says:
-c, --characters=LIST select only these charactersSo both options should be valid. Is this an issue with the current version of cut being used by the GH action?
There was a problem hiding this comment.
no, sorry it's just that on osx (where I tested the script) cut doesn't support --character but only -c.
There was a problem hiding this comment.
That's why we can't have nice things :(
The outdated shell utils that macOS ships with are a pain.
There was a problem hiding this comment.
no, sorry it's just that on osx (where I tested the script) cut doesn't support --character but only -c.
Right, so can you revert that change?
r0qs
left a comment
r0qs
left a comment
There was a problem hiding this comment.
Besides one comment. The PR looks good to me.
cameel
changed the title
purge_paths in sync-r2.sh
cameel
changed the title
purge_paths in sync-r2.shpurge_paths in sync-r2.sh by removing unnecessary leading slashes
cameel
changed the title
purge_paths in sync-r2.sh by removing unnecessary leading slashespurge_paths in sync-r2.sh by removing unnecessary leading slashes
r0qs
left a comment
r0qs
left a comment
There was a problem hiding this comment.
I'm fine with the change in https://github.com/argotorg/solc-bin/pull/178/changes#r2636402198 if that makes easier to test locally in different environments.
Fix cut command to use -c instead of --characters.
Co-authored-by: Kamil Śliwak <kamil.sliwak@codepoets.it>
marcocastignoli
force-pushed
the
fix-sync-r2-purge-payload
branch
from
1bc9a4f to
b6ca119
Compare
github-project-automation
bot
moved this from Sprint - Needs Review
to Sprint - Done
in Sourcify Public
purge_paths, a list containing the files to be purged was created by adding resources with the wrong path "https://binaries.soliditylang.org//bin/list.json" instead of "https://binaries.soliditylang.org/bin/list.json" (notice the double slash beforebin/list.json).