Skip to content

Add shfmt workflow #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thilinarmtb merged 6 commits into from
Dec 18, 2025
Merged

Add shfmt workflow #462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4bae621
Add shfmt github workflow
thilinarmtb Dec 17, 2025
5d9b13f
Check if the workflow fails with i=4
thilinarmtb Dec 17, 2025
f5b2011
Run shfmt manually instead of the GitHub action
thilinarmtb Dec 17, 2025
e637011
Remove the negative test
thilinarmtb Dec 17, 2025
2bdca41
Format `.sh.in` files as well
thilinarmtb Dec 17, 2025
b0b6974
Format `*.sh.in` files
thilinarmtb Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions .github/workflows/shfmt.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
name: shfmt
on:
push:
pull_request:
branches:
- main
- devel
env:
FLAGS: "-i 2 -ci -d"
jobs:
shfmt:
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v4
- name: Install shfmt
run: |
curl -sS https://webi.sh/shfmt | sh
- name: Run shfmt check
run: |
# check formatting of standard bash files
shfmt ${FLAGS} .
# check formatting of `*.sh.in` files
sh_in=$(find . -iname *.sh.in)
shfmt ${FLAGS} ${sh_in}
132 changes: 74 additions & 58 deletions backends/cuda/tracer_cuda.sh.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,65 +16,94 @@ whichlib() {

# In OpenSUSE ldconfig, is in '/sbin'.
PATH=$PATH:/sbin ldconfig -vNX $(echo $LD_LIBRARY_PATH | sed 's/:/ /g') 2>/dev/null |
awk -v p=$1 'match($1, ":") { header=substr($1, 1, length($1)-1)} \
awk -v p=$1 'match($1, ":") { header=substr($1, 1, length($1)-1)} \
match($1, "^lib") && match($1, p) { print header "/" $1}'
}

whichlib64_head() {
# This function return only the first lib found
# This avoid a broken pipe error when the old pattern `whichlib64 $foo | head - n1` was used
for lib in $(whichlib $1)
do
if objdump -a $lib | grep 64 > /dev/null; then
for lib in $(whichlib $1); do
if objdump -a $lib | grep 64 >/dev/null; then
echo $lib
break
fi
done
}

display_help() {
echo "Usage:"
echo " $(basename $0) [options] [--] <application> <application-arguments>"
echo " --help Show this screen"
echo " --version Print the version string"
echo " --cudart Trace CUDA runtime on top of CUDA driver"
echo " -a, --arguments Extract argument infos and values"
echo " -p, --profiling Enable profiling"
echo " -e, --exports Trace export functions"
echo " -v, --visualize Visualize trace on thefly"
echo " --properties Dump devices infos"
echo " --sample Sample performance counters"
exit 1
echo "Usage:"
echo " $(basename $0) [options] [--] <application> <application-arguments>"
echo " --help Show this screen"
echo " --version Print the version string"
echo " --cudart Trace CUDA runtime on top of CUDA driver"
echo " -a, --arguments Extract argument infos and values"
echo " -p, --profiling Enable profiling"
echo " -e, --exports Trace export functions"
echo " -v, --visualize Visualize trace on thefly"
echo " --properties Dump devices infos"
echo " --sample Sample performance counters"
exit 1
}

display_version() {
cat $datadir/version
exit 1
cat $datadir/version
exit 1
}

while true; do
case "$1" in
--help ) display_help; exit;;
--version ) display_version; exit;;
--cudart ) shift; cudart=1;;
-a | --arguments ) shift; arguments=1;;
-p | --profiling ) shift; profiling=1; export LTTNG_UST_CUDA_PROFILE=1;;
-e | --exports ) shift; exports=1;;
-v | --visualize ) shift; lttng_view=1;;
--properties ) shift; properties=1;;
--sample ) shift; sample=1;;
-- ) shift; break ;;
* ) break ;;
--help)
display_help
exit
;;
--version)
display_version
exit
;;
--cudart)
shift
cudart=1
;;
-a | --arguments)
shift
arguments=1
;;
-p | --profiling)
shift
profiling=1
export LTTNG_UST_CUDA_PROFILE=1
;;
-e | --exports)
shift
exports=1
;;
-v | --visualize)
shift
lttng_view=1
;;
--properties)
shift
properties=1
;;
--sample)
shift
sample=1
;;
--)
shift
break
;;
*) break ;;
esac
done

if [ "$#" -eq 0 ]; then
display_help
display_help
fi

lttng-sessiond --daemonize --quiet
if [ ! -z "$lttng_view" ]
then
if [ ! -z "$lttng_view" ]; then
lttng-relayd --daemonize
lttng create thapi-cuda-session --live
else
Expand All @@ -83,37 +112,29 @@ fi
lttng enable-channel --userspace --blocking-timeout=inf blocking-channel
lttng add-context --userspace --channel=blocking-channel -t vpid -t vtid
lttng enable-event --channel=blocking-channel --userspace lttng_ust_cuda:*
if [ ! -z "$cudart" ]
then
if [ ! -z "$cudart" ]; then
lttng enable-event --channel=blocking-channel --userspace lttng_ust_cudart:*
fi
if [ ! -z "$arguments" ]
then
if [ ! -z "$arguments" ]; then
lttng enable-event --channel=blocking-channel --userspace lttng_ust_cuda_args:*
fi
if [ ! -z "$profiling" ]
then
if [ ! -z "$profiling" ]; then
lttng enable-event --channel=blocking-channel --userspace lttng_ust_cuda_profiling:*
fi
if [ ! -z "$exports" ]
then
if [ ! -z "$exports" ]; then
lttng enable-event --channel=blocking-channel --userspace lttng_ust_cuda_exports:*
fi
if [ ! -z "$properties" ]
then
if [ ! -z "$properties" ]; then
lttng enable-event --channel=blocking-channel --userspace lttng_ust_cuda_properties:*
fi
if [ ! -z "$sample" ]
then
if [ ! -z "$sample" ]; then
export LTTNG_UST_SAMPLING=1
lttng enable-channel --userspace nonblocking-channel
lttng enable-event --channel=nonblocking-channel --userspace lttng_ust_sampling:*
fi
if [ -z "$LTTNG_UST_CUDA_LIBCUDA" ]
then
if [ -z "$LTTNG_UST_CUDA_LIBCUDA" ]; then
LTTNG_UST_CUDA_LIBCUDA=$(whichlib64_head libcuda.so)
if [ -n "$LTTNG_UST_CUDA_LIBCUDA" ]
then
if [ -n "$LTTNG_UST_CUDA_LIBCUDA" ]; then
export LTTNG_UST_CUDA_LIBCUDA="$LTTNG_UST_CUDA_LIBCUDA"
export LD_LIBRARY_PATH=$pkglibdir/cuda:$LD_LIBRARY_PATH
fi
Expand All @@ -123,13 +144,10 @@ fi
export LD_PRELOAD=$pkglibdir/cuda/libcuda.so:$LD_PRELOAD
export LTTNG_UST_ALLOW_BLOCKING=1
export LTTNG_UST_CUDA_VERBOSE=1
if [ ! -z "$cudart" ]
then
if [ -z "$LTTNG_UST_CUDART_LIBCUDART" ]
then
if [ ! -z "$cudart" ]; then
if [ -z "$LTTNG_UST_CUDART_LIBCUDART" ]; then
LTTNG_UST_CUDART_LIBCUDART=$(whichlib64_head libcudart.so)
if [ -n "$LTTNG_UST_CUDART_LIBCUDART" ]
then
if [ -n "$LTTNG_UST_CUDART_LIBCUDART" ]; then
export LTTNG_UST_CUDART_LIBCUDART="$LTTNG_UST_CUDART_LIBCUDART"
export LD_LIBRARY_PATH=$pkglibdir/cudart:$LD_LIBRARY_PATH
fi
Expand All @@ -149,15 +167,13 @@ ctrl_c() {

trap ctrl_c INT

if [ ! -z "$lttng_view" ]
then
if [ ! -z "$lttng_view" ]; then
lttng view --viewer="babeltrace_thapi --backend cuda --context --live" &
PID=$!
fi
"$@"
lttng stop
lttng destroy
if [ ! -z "$lttng_view" ]
then
if [ ! -z "$lttng_view" ]; then
wait $PID
fi
62 changes: 34 additions & 28 deletions backends/hip/tracer_hip.sh.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,53 +16,63 @@ whichlib() {

# In OpenSUSE ldconfig, is in '/sbin'.
PATH=$PATH:/sbin ldconfig -vNX $(echo $LD_LIBRARY_PATH | sed 's/:/ /g') 2>/dev/null |
awk -v p=$1 'match($1, ":") { header=substr($1, 1, length($1)-1)} \
awk -v p=$1 'match($1, ":") { header=substr($1, 1, length($1)-1)} \
match($1, "^lib") && match($1, p) { print header "/" $1}'
}

whichlib64_head() {
# This function return only the first lib found
# This avoid a broken pipe error when the old pattern `whichlib64 $foo | head - n1` was used
for lib in $(whichlib $1)
do
if objdump -a $lib | grep 64 > /dev/null; then
for lib in $(whichlib $1); do
if objdump -a $lib | grep 64 >/dev/null; then
echo $lib
break
fi
done
}

display_help() {
echo "Usage:"
echo " $(basename $0) [options] [--] <application> <application-arguments>"
echo " --help Show this screen"
echo " --version Print the version string"
echo " -v, --visualize Visualize trace on the fly"
exit 1
echo "Usage:"
echo " $(basename $0) [options] [--] <application> <application-arguments>"
echo " --help Show this screen"
echo " --version Print the version string"
echo " -v, --visualize Visualize trace on the fly"
exit 1
}

display_version() {
cat $datadir/version
exit 1
cat $datadir/version
exit 1
}

while true; do
case "$1" in
--help ) display_help; exit;;
--version ) display_version; exit;;
-v | --visualize ) shift; lttng_view=1;;
-- ) shift; break ;;
* ) break ;;
--help)
display_help
exit
;;
--version)
display_version
exit
;;
-v | --visualize)
shift
lttng_view=1
;;
--)
shift
break
;;
*) break ;;
esac
done

if [ "$#" -eq 0 ]; then
display_help
display_help
fi

lttng-sessiond --daemonize --quiet
if [ ! -z "$lttng_view" ]
then
if [ ! -z "$lttng_view" ]; then
lttng-relayd --daemonize
lttng create thapi-hip-session --live
else
Expand All @@ -71,11 +81,9 @@ fi
lttng enable-channel --userspace --blocking-timeout=inf blocking-channel
lttng add-context --userspace --channel=blocking-channel -t vpid -t vtid
lttng enable-event --channel=blocking-channel --userspace lttng_ust_hip:*
if [ -z "$LTTNG_UST_HIP_LIBAMDHIP64" ]
then
if [ -z "$LTTNG_UST_HIP_LIBAMDHIP64" ]; then
LTTNG_UST_HIP_LIBAMDHIP64=$(whichlib64_head libamdhip64.so)
if [ -n "$LTTNG_UST_HIP_LIBAMDHIP64" ]
then
if [ -n "$LTTNG_UST_HIP_LIBAMDHIP64" ]; then
export LTTNG_UST_HIP_LIBAMDHIP64="$LTTNG_UST_HIP_LIBAMDHIP64"
export LD_LIBRARY_PATH=$pkglibdir/hip:$LD_LIBRARY_PATH
fi
Expand All @@ -95,15 +103,13 @@ ctrl_c() {

trap ctrl_c INT

if [ ! -z "$lttng_view" ]
then
if [ ! -z "$lttng_view" ]; then
lttng view --viewer="babeltrace_thapi --backend hip --context --live" &
PID=$!
fi
"$@"
lttng stop
lttng destroy
if [ ! -z "$lttng_view" ]
then
if [ ! -z "$lttng_view" ]; then
wait $PID
fi
Loading